Logger issues

From VistrailsWiki
Revision as of 20:12, 24 October 2013 by Remi (talk | contribs)
Jump to navigation Jump to search

I found a number of problems with the way the logger (LogController) works at the moment. This is tightly integrated with the interpreter, so it is critical, and changing things could break backward compatibility (although very few packages should have to use the logger at all; it is outside of the standard compute()'s role).

Issues

  • The LogController ("logger") is wrapped in something else that notices both the logger and the view, and that wrapper is set on the Module (as the "logging" attribute).
  • Progress reporting for loops is broken (although it is probably a small issue).
  • The LogController uses an interpreter-global stack of executions. This is incompatible with the multithreaded-interpreter effort, where module do not execute in any sensible order.
  • There are issues with duplicated modules (different module objects but with same signature, so possibly same persistent object) #765

Branches

  • logger-rewrite
  • raise-modulesuspended